Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: CNS-single-provider #1689

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

feat: CNS-single-provider #1689

wants to merge 30 commits into from

Conversation

Yaroms
Copy link
Collaborator

@Yaroms Yaroms commented Sep 11, 2024

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

Test Results

1 760 tests   - 445   1 737 ✅  - 468   23m 28s ⏱️ - 1m 54s
  145 suites ±  0       0 💤 ±  0 
    7 files   ±  0      23 ❌ + 23 

For more details on these failures, see this check.

Results for commit cea2532. ± Comparison against base commit 6278d1a.

This pull request removes 445 tests. 
github.com/lavanet/lava/v3/x/dualstaking/keeper ‑ TestDelegateFail/bad_chainID
github.com/lavanet/lava/v3/x/dualstaking/keeper ‑ TestRedelegateFail/bad_chainID
github.com/lavanet/lava/v3/x/dualstaking/keeper ‑ TestUnbondFail/bad_chainID
github.com/lavanet/lava/v3/x/pairing/keeper ‑ TestAddKeyCreateProject
github.com/lavanet/lava/v3/x/pairing/keeper ‑ TestAddProjectAfterPlanUpdate
github.com/lavanet/lava/v3/x/pairing/keeper ‑ TestAddonPairing
github.com/lavanet/lava/v3/x/pairing/keeper ‑ TestAddonPairing/addon_in_plan
github.com/lavanet/lava/v3/x/pairing/keeper ‑ TestAddonPairing/addon_in_proj
github.com/lavanet/lava/v3/x/pairing/keeper ‑ TestAddonPairing/addon_in_subsc
github.com/lavanet/lava/v3/x/pairing/keeper ‑ TestAddonPairing/empty
…

♻️ This comment has been updated with latest results.

@Yaroms Yaroms marked this pull request as ready for review September 19, 2024 14:47
@luis02lopez luis02lopez mentioned this pull request Sep 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omerlavanet omerlavanet Awaiting requested review from omerlavanet

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
C:proto C:protocol C:x/dualstaking C:x/epochstorage C:x/pairing C:x/subscription size/XXL Team:Consensus Team:Protocol Type: CI Type: Proto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yaroms @luis02lopez